----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/17/#review199 -----------------------------------------------------------
config/roles/testrole/role.py http://reviewboard-fedoraserver.rhcloud.com/r/17/#comment113
shouldn't you change get_property -> do_get_property ?
config/roles/testrole/role.py http://reviewboard-fedoraserver.rhcloud.com/r/17/#comment112
shouldn't you change the examples to do_get_dbus_property() too ?
config/roles/testrole/role.py http://reviewboard-fedoraserver.rhcloud.com/r/17/#comment111
is this improperly indented ? sounds like it should be in do_get_dbus_property() but it isn't this way
- Simo Sorce
On July 22, 2014, 3:35 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/17/
(Updated July 22, 2014, 3:35 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Simplifies the role interface Role cleanup by dropping "failonthis" setting
Diffs
config/roles/testrole/role.py 2f077c62b4a8027e7783a2e08c84bc9c9715393e src/rolekit/server/rolebase.py 50b5685a038789d02d3f3b0451f5edaecc187964
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/17/diff/
Testing
Thanks,
Thomas Woerner