Re: Review Request 155: Allow roles to raise INVALID_VALUE and remove the instance
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/155/
-----------------------------------------------------------
(Updated March 31, 2015, 11:25 p.m.)
Status
------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
Repository: rolekit
Description
-------
Previously, we could only do limited checks on those options that
were provided to the API, but this didn't allow us to check for
missing attributes or attributes whose value is dependent on
another setting, etc.
With this patch, roles will be allowed to
raise RolekitError(INVALID_VALUE)
as long as they have not yet made any changes to the systemm
Diffs
-----
src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/155/diff/
Testing
-------
Attempted to create a database role with no settings file (and therefore no database name). The deployment failed but no invalid instance was left behind.
Thanks,
Stephen Gallagher
9 years
Re: Review Request 155: Allow roles to raise INVALID_VALUE and remove the instance
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/155/#review416
-----------------------------------------------------------
Ship it!
Ship It!
- Simo Sorce
On March 31, 2015, 7:26 p.m., Stephen Gallagher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-fedoraserver.rhcloud.com/r/155/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 7:26 p.m.)
>
>
> Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
>
>
> Repository: rolekit
>
>
> Description
> -------
>
> Previously, we could only do limited checks on those options that
> were provided to the API, but this didn't allow us to check for
> missing attributes or attributes whose value is dependent on
> another setting, etc.
>
> With this patch, roles will be allowed to
> raise RolekitError(INVALID_VALUE)
> as long as they have not yet made any changes to the systemm
>
>
> Diffs
> -----
>
> src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
>
> Diff: http://reviewboard-fedoraserver.rhcloud.com/r/155/diff/
>
>
> Testing
> -------
>
> Attempted to create a database role with no settings file (and therefore no database name). The deployment failed but no invalid instance was left behind.
>
>
> Thanks,
>
> Stephen Gallagher
>
>
9 years
Review Request 155: Allow roles to raise INVALID_VALUE and remove the instance
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/155/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Previously, we could only do limited checks on those options that
were provided to the API, but this didn't allow us to check for
missing attributes or attributes whose value is dependent on
another setting, etc.
With this patch, roles will be allowed to
raise RolekitError(INVALID_VALUE)
as long as they have not yet made any changes to the systemm
Diffs
-----
src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/155/diff/
Testing
-------
Attempted to create a database role with no settings file (and therefore no database name). The deployment failed but no invalid instance was left behind.
Thanks,
Stephen Gallagher
9 years
Re: Review Request 147: DB: Support multiple instances
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/147/
-----------------------------------------------------------
(Updated March 25, 2015, 8:26 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
Changes
-------
Update based on review.
Bugs: 41
https://fedorahosted.org/rolekit/ticket/41
Repository: rolekit
Description
-------
DB: Support multiple instances
Diffs (updated)
-----
config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
src/rolekit/config/__init__.py.in cd0f14f5519247d31ee1380bf5986f701797af78
src/rolekit/errors.py 47a9c95d3bd2d62f0c008693e6d5eb7a48632d67
src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/147/diff/
Testing
-------
Thanks,
Stephen Gallagher
9 years, 1 month
Re: Review Request 148: DB: Set a default for DB owner
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/148/
-----------------------------------------------------------
(Updated March 25, 2015, 8:38 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
Changes
-------
Throw an exception if we try to set a password on an existing user.
Repository: rolekit
Description (updated)
-------
We'll use db_owner if it's unspecified.
Diffs (updated)
-----
config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
doc/xml/rolekit.roles.databaseserver.xml 112a40c9d8fb0a268e74bc022857bef4587103e8
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/148/diff/
Testing
-------
Thanks,
Stephen Gallagher
9 years, 1 month
Review Request 153: DB: Suppress passwords from settings
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/153/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Only display the password in the settings attributes if it was
automatically generated.
Diffs
-----
config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
doc/xml/rolekit.roles.databaseserver.xml 112a40c9d8fb0a268e74bc022857bef4587103e8
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/153/diff/
Testing
-------
Thanks,
Stephen Gallagher
9 years, 1 month