Re: Review Request 149: DB: Implement decommission
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/149/#review407
-----------------------------------------------------------
config/roles/databaseserver/role.py (line 289)
<http://reviewboard-fedoraserver.rhcloud.com/r/149/#comment234>
Please use self._parent instead of self._dbusrole
- Thomas Woerner
On March 25, 2015, 1:56 a.m., Stephen Gallagher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-fedoraserver.rhcloud.com/r/149/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 1:56 a.m.)
>
>
> Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
>
>
> Bugs: 40
> https://fedorahosted.org/rolekit/ticket/40
>
>
> Repository: rolekit
>
>
> Description
> -------
>
> DB: Implement decommission
>
>
> Diffs
> -----
>
> config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
>
> Diff: http://reviewboard-fedoraserver.rhcloud.com/r/149/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephen Gallagher
>
>
9 years, 1 month
Re: Review Request 148: DB: Set a default for DB owner
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/148/#review405
-----------------------------------------------------------
config/roles/databaseserver/role.py (line 167)
<http://reviewboard-fedoraserver.rhcloud.com/r/148/#comment232>
If the admin was defining a password for the owner, it will be silently not be set if the owner already exists.
Either set it (only if not autogenerated) or print out a warning and add this behaviour also to the documentation.
- Thomas Woerner
On March 25, 2015, 1:54 a.m., Stephen Gallagher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-fedoraserver.rhcloud.com/r/148/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 1:54 a.m.)
>
>
> Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
>
>
> Repository: rolekit
>
>
> Description
> -------
>
> We'll use <database>_owner if it's unspecified.
>
>
> Diffs
> -----
>
> config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
> doc/xml/rolekit.roles.databaseserver.xml 112a40c9d8fb0a268e74bc022857bef4587103e8
>
> Diff: http://reviewboard-fedoraserver.rhcloud.com/r/148/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephen Gallagher
>
>
9 years, 1 month
Re: Review Request 147: DB: Support multiple instances
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/147/#review404
-----------------------------------------------------------
src/rolekit/server/dbusrole.py (line 330)
<http://reviewboard-fedoraserver.rhcloud.com/r/147/#comment231>
See above.
- Thomas Woerner
On March 25, 2015, 1:54 a.m., Stephen Gallagher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-fedoraserver.rhcloud.com/r/147/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 1:54 a.m.)
>
>
> Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
>
>
> Bugs: 41
> https://fedorahosted.org/rolekit/ticket/41
>
>
> Repository: rolekit
>
>
> Description
> -------
>
> DB: Support multiple instances
>
>
> Diffs
> -----
>
> config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
> src/rolekit/config/__init__.py.in cd0f14f5519247d31ee1380bf5986f701797af78
> src/rolekit/errors.py 47a9c95d3bd2d62f0c008693e6d5eb7a48632d67
> src/rolekit/server/dbusrole.py 47ed16fb553cbf10490921750814755361090a67
> src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
>
> Diff: http://reviewboard-fedoraserver.rhcloud.com/r/147/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephen Gallagher
>
>
9 years, 1 month
Re: Review Request 147: DB: Support multiple instances
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/147/#review403
-----------------------------------------------------------
src/rolekit/server/dbusrole.py (line 93)
<http://reviewboard-fedoraserver.rhcloud.com/r/147/#comment230>
This is also not needed.
- Thomas Woerner
On March 25, 2015, 1:54 a.m., Stephen Gallagher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-fedoraserver.rhcloud.com/r/147/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 1:54 a.m.)
>
>
> Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
>
>
> Bugs: 41
> https://fedorahosted.org/rolekit/ticket/41
>
>
> Repository: rolekit
>
>
> Description
> -------
>
> DB: Support multiple instances
>
>
> Diffs
> -----
>
> config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
> src/rolekit/config/__init__.py.in cd0f14f5519247d31ee1380bf5986f701797af78
> src/rolekit/errors.py 47a9c95d3bd2d62f0c008693e6d5eb7a48632d67
> src/rolekit/server/dbusrole.py 47ed16fb553cbf10490921750814755361090a67
> src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
>
> Diff: http://reviewboard-fedoraserver.rhcloud.com/r/147/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephen Gallagher
>
>
9 years, 1 month
Re: Review Request 147: DB: Support multiple instances
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/147/#review402
-----------------------------------------------------------
config/roles/databaseserver/role.py (line 98)
<http://reviewboard-fedoraserver.rhcloud.com/r/147/#comment228>
Please use self._parent:
self._parent.get_instances().values()
src/rolekit/server/rolebase.py (line 79)
<http://reviewboard-fedoraserver.rhcloud.com/r/147/#comment229>
This is not needed: self._parent is already the dbusrole
- Thomas Woerner
On March 25, 2015, 1:54 a.m., Stephen Gallagher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-fedoraserver.rhcloud.com/r/147/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 1:54 a.m.)
>
>
> Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce, and Thomas Woerner.
>
>
> Bugs: 41
> https://fedorahosted.org/rolekit/ticket/41
>
>
> Repository: rolekit
>
>
> Description
> -------
>
> DB: Support multiple instances
>
>
> Diffs
> -----
>
> config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
> src/rolekit/config/__init__.py.in cd0f14f5519247d31ee1380bf5986f701797af78
> src/rolekit/errors.py 47a9c95d3bd2d62f0c008693e6d5eb7a48632d67
> src/rolekit/server/dbusrole.py 47ed16fb553cbf10490921750814755361090a67
> src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
>
> Diff: http://reviewboard-fedoraserver.rhcloud.com/r/147/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Stephen Gallagher
>
>
9 years, 1 month