On March 24, 2015, 7:11 p.m., Simo Sorce wrote:
> config/roles/databaseserver/role.py, line 198
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/147/diff/2/?file=611#file61...
>
> Should you also check is a .rksave file was generated and restore it ?
I'm opening
https://fedorahosted.org/rolekit/ticket/42 to track this. I don't
think it's worth the effort given how unlikely it is to fail.
On March 24, 2015, 7:11 p.m., Simo Sorce wrote:
> config/roles/databaseserver/role.py, line 218
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/147/diff/2/?file=611#file61...
>
> Is this really necessary only on first_instance ?
> The comment makes me believe it should be always performed ?
The postgresql server needs to be restarted to accept the changes to pg_hba.conf and
postgresql.conf, which we only need to do once, for the first deployment. It doesn't
need to be restarted to accept new users, databases etc.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/147/#review399
-----------------------------------------------------------
On March 20, 2015, 6:48 p.m., Stephen Gallagher wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/147/
-----------------------------------------------------------
(Updated March 20, 2015, 6:48 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Bugs: 41
https://fedorahosted.org/rolekit/ticket/41
Repository: rolekit
Description
-------
DB: Support multiple instances
Diffs
-----
config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12
src/rolekit/config/__init__.py.in cd0f14f5519247d31ee1380bf5986f701797af78
src/rolekit/server/dbusrole.py 47ed16fb553cbf10490921750814755361090a67
src/rolekit/server/rolebase.py 57485a31a94d3be0ca15eb9d97df7a7654d2e6fc
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/147/diff/
Testing
-------
Thanks,
Stephen Gallagher