Review Request 179: Support deferred deployment
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/179/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Bugs: 1
http://github.com/libre-server/rolekit/issues#issue/1
Repository: rolekit
Description
-------
We want to be able to support configuring role deployments during
automated system setup (such as Anaconda kickstart for Fedora and
Red Hat Enterprise Linux systems). With this patch, we add a
--next-boot argument to 'rolectl deploy'. This will cause a one-
time systemd service unit to be created and configured to run at
the first boot.
This service unit will execute the real 'rolectl deploy' after the
network is online and will process the role deployment, then
delete the temporary files. These files will not be deleted in the
event of an error.
Fixes https://github.com/libre-server/rolekit/issues/1
Diffs
-----
config/Makefile.am 480f74f450bb2c6397848e20e3973be806123302
rolekit.spec 0acce035a3745572226e93443515eb0d20b0c77e
src/Makefile.am bbcdf37b417416fa0a5eeeb800a81417f3b81380
src/rolectl ac36bb94c80992c51dcadfa24d93806bc6598954
src/rolekit/config/__init__.py.in d9295f37061576fe697402206e18342e0f0a22be
src/rolekit/rolectl/__init__.py PRE-CREATION
src/rolekit/server/io/rolesettings.py 18f4871faf87ba23d21a3f9bc2c13b14463a8ccf
src/rolekit/server/rolebase.py b8bc640bd70fe995e4183c71bd77b355a42a4228
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/179/diff/
Testing
-------
Deployed the memcache role with --next-boot. Tested it by doing 'systemctl start pendingrole-memcache-name.service'
It has not been tested with an actual kickstart yet; I am waiting for Alpha RC1 to arrive and will test it with that.
Thanks,
Stephen Gallagher
8 years, 8 months
Review Request 197: New sanitize (settings) for role instances
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/197/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Sanitize can be used to for example forget passwords of role instances or
to reset other sensitive data from the settings.
The sanitization is done in the role, as rolekit does not know which
settings need to be reset. The role needs to implement the do_sanitize
method for this.
This is currently implemented for password in the databaseserver role and
for dm_password in the domaincontroller role.
Fixes https://github.com/libre-server/rolekit/issues/33
Diffs
-----
config/roles/databaseserver/role.py aff6b12fb632d100674392b89427cfea93fb33e0
config/roles/domaincontroller/role.py 36f1a67cdb187c6433fb2b70f8473ba3c66007ed
doc/xml/rolectl.xml 6048870abcf21942d37a87275029ad3fed311258
doc/xml/rolekit.dbus.xml 3ec00333b8ed87fad7f26ffbb2f835135aef2b07
shell-completion/bash/rolectl b32b71e7713d7a40236db07faae8ecca481753dd
src/rolectl ade941d99ce04d62b17714ee4c624d2b73249281
src/rolekit/client.py 0bb65cc920e1d65c4765dd9ec0bacc16c474c27f
src/rolekit/server/rolebase.py 121a9b706ee2dda37eff116b8fc7a50143b2e1a6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/197/diff/
Testing
-------
Thanks,
Thomas Woerner
8 years, 8 months
Review Request 193: Move instance name generation into RoleSettings
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/193/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
This will allow us to extend this when we add pendingroles and use
the same routines for generating them.
Diffs
-----
src/rolekit/server/io/rolesettings.py 18f4871faf87ba23d21a3f9bc2c13b14463a8ccf
src/rolekit/server/dbusrole.py 47ed16fb553cbf10490921750814755361090a67
doc/xml/rolekit.dbus.xml 1f876763a5189935c42f3c779d659f9e2b3bf987
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/193/diff/
Testing
-------
Thanks,
Stephen Gallagher
8 years, 8 months
Review Request 178: Add modified configparser for systemd unit files
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/178/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
This is a temporary measure; this code will be going upstream into python-systemd in the near future, but for now we will carry it in rolekit.
There is one known limitation to this implementation; It does not support reading unit files with multiline values. This won't be an issue in rolekit, but it's preventing it from going upstream to python-systemd at the moment.
Diffs
-----
src/rolekit/server/io/systemd.py 3b6bca678f70a608e2d54bb3615523dec7ab9271
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/178/diff/
Testing
-------
Testing performed manually by loading the python module and writing out some sample unit files. Also tested with the kickstart patch.
Thanks,
Stephen Gallagher
8 years, 8 months