Review Request 189: async: log tracebacks with (most) exceptions

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/189/
-----------------------------------------------------------

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

async: log tracebacks with (most) exceptions


Diffs
-----

  src/rolekit/async.py 423b4396b0e61951e18ff7cd9357cffb4b162c74 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/


Testing
-------


Thanks,

Nils Philippsen

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/189/#review468
-----------------------------------------------------------



src/rolekit/async.py (lines 170 - 175)
<http://reviewboard-fedoraserver.rhcloud.com/r/189/#comment265>

    This change really needs a comment to explain it. Why is it okay to call
log.exception() if we have something other than a RolekitError here? That disagrees with
the comment on lines 170-171.


- Stephen Gallagher


On Aug. 12, 2015, 3:43 p.m., Nils Philippsen wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/189/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 12, 2015, 3:43 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  async: log tracebacks with (most) exceptions
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/async.py 423b4396b0e61951e18ff7cd9357cffb4b162c74 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Nils Philippsen
>  
>

[Stephen Gallagher]

>  On Aug. 18, 2015, 7:35 nachm., Stephen Gallagher wrote:
>  > src/rolekit/async.py, lines 170-175
>  >
> <http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/1/?file=848#file84...
>  >
>  >     This change really needs a comment to explain it. Why is it okay to call
> log.exception() if we have something other than a RolekitError here? That disagrees with
> the comment on lines 170-171. 
I can't say much about the previous comment because I didn't write it :). All I
know is that I had some issue throwing exceptions on the daemon side and no way to find
out where exactly it bombed. Adding the call to `log.exception()` logged the complete
traceback just as I would expect it. Do you have some background for me? Then I could
maybe change the existing comment to reflect what's really going on.


- Nils


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/189/#review468
-----------------------------------------------------------


On Aug. 12, 2015, 5:43 nachm., Nils Philippsen wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/189/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 12, 2015, 5:43 nachm.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  async: log tracebacks with (most) exceptions
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/async.py 423b4396b0e61951e18ff7cd9357cffb4b162c74 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Nils Philippsen
>  
>

[Stephen Gallagher]

>  On Aug. 18, 2015, 5:35 p.m., Stephen Gallagher wrote:
>  > src/rolekit/async.py, lines 170-175
>  >
> <http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/1/?file=848#file84...
>  >
>  >     This change really needs a comment to explain it. Why is it okay to call
> log.exception() if we have something other than a RolekitError here? That disagrees with
> the comment on lines 170-171.
>  
>  Nils Philippsen wrote:
>      I can't say much about the previous comment because I didn't write it :). All
> I know is that I had some issue throwing exceptions on the daemon side and no way to find
> out where exactly it bombed. Adding the call to `log.exception()` logged the complete
> traceback just as I would expect it. Do you have some background for me? Then I could
> maybe change the existing comment to reflect what's really going on. 
I think the comment is not correct. A traceback in this place is properly logged in my
tests.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/189/#review468
-----------------------------------------------------------


On Aug. 12, 2015, 3:43 p.m., Nils Philippsen wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/189/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 12, 2015, 3:43 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  async: log tracebacks with (most) exceptions
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/async.py 423b4396b0e61951e18ff7cd9357cffb4b162c74 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Nils Philippsen
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/189/#review494
-----------------------------------------------------------

Ship it!


Ship It!

- Stephen Gallagher


On Aug. 12, 2015, 3:43 p.m., Nils Philippsen wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/189/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 12, 2015, 3:43 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  async: log tracebacks with (most) exceptions
>  
>  
>  Diffs
>  -----
>  
>    src/rolekit/async.py 423b4396b0e61951e18ff7cd9357cffb4b162c74 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Nils Philippsen
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/189/
-----------------------------------------------------------

(Updated Aug. 26, 2015, 6:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

async: log tracebacks with (most) exceptions


Diffs
-----

  src/rolekit/async.py 423b4396b0e61951e18ff7cd9357cffb4b162c74 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/


Testing
-------


Thanks,

Nils Philippsen