-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/189/#review468
-----------------------------------------------------------
src/rolekit/async.py (lines 170 - 175)
<
http://reviewboard-fedoraserver.rhcloud.com/r/189/#comment265>
This change really needs a comment to explain it. Why is it okay to call
log.exception() if we have something other than a RolekitError here? That disagrees with
the comment on lines 170-171.
- Stephen Gallagher
On Aug. 12, 2015, 3:43 p.m., Nils Philippsen wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/189/
-----------------------------------------------------------
(Updated Aug. 12, 2015, 3:43 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
async: log tracebacks with (most) exceptions
Diffs
-----
src/rolekit/async.py 423b4396b0e61951e18ff7cd9357cffb4b162c74
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/189/diff/
Testing
-------
Thanks,
Nils Philippsen