Re: Review Request 148: DB: Set a default for DB owner

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/148/#review405
-----------------------------------------------------------



config/roles/databaseserver/role.py (line 167)
<http://reviewboard-fedoraserver.rhcloud.com/r/148/#comment232>

    If the admin was defining a password for the owner, it will be silently not be set if
the owner already exists.
    
    Either set it (only if not autogenerated) or print out a warning and add this
behaviour also to the documentation.


- Thomas Woerner


On March 25, 2015, 1:54 a.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/148/
>  -----------------------------------------------------------
>  
>  (Updated March 25, 2015, 1:54 a.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
> and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  We'll use <database>_owner if it's unspecified.
>  
>  
>  Diffs
>  -----
>  
>    config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12 
>    doc/xml/rolekit.roles.databaseserver.xml 112a40c9d8fb0a268e74bc022857bef4587103e8 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/148/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

Review Request 148: DB: Set a default for DB owner

[Stephen Gallagher]

>  On March 25, 2015, 7:56 p.m., Thomas Woerner wrote:
>  > config/roles/databaseserver/role.py, line 167
>  >
> <http://reviewboard-fedoraserver.rhcloud.com/r/148/diff/2/?file=621#file62...
>  >
>  >     If the admin was defining a password for the owner, it will be silently not be
> set if the owner already exists.
>  >     
>  >     Either set it (only if not autogenerated) or print out a warning and add this
> behaviour also to the documentation. 
At best fail in this case.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/148/#review405
-----------------------------------------------------------


On March 25, 2015, 1:54 a.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/148/
>  -----------------------------------------------------------
>  
>  (Updated March 25, 2015, 1:54 a.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, Simo Sorce,
> and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  We'll use <database>_owner if it's unspecified.
>  
>  
>  Diffs
>  -----
>  
>    config/roles/databaseserver/role.py e2133535f4d8e59b0c1c27f8d6e171f8910d4d12 
>    doc/xml/rolekit.roles.databaseserver.xml 112a40c9d8fb0a268e74bc022857bef4587103e8 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/148/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>