-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/245/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
When specifying forwarders for the domain controller, we were checking
that both the IPv4 and IPv6 forwarders are present, but we actually
only strictly need one or the other (and many environments don't even
have both). Change it so that we check for at least one instead.
Fixes https://github.com/libre-server/rolekit/issues/64
Diffs
-----
config/roles/domaincontroller/role.py 094a2e3feb7a5d39383f3d20e93aad7849ed8e1b
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/245/diff/
Testing
-------
Tested deployment of a domain controller with only a single IPv4 address.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/240/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Some roles using containers require additional memory. Might as
well just make sure we always have 2GB available.
Diffs
-----
Vagrantfile 1ca99b7de19d525d9099b3ff413799a8b5e5ce68
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/240/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/243/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
remove obsolete imports
Diffs
-----
src/rolekit/server/rolebase.py e573f56ae52a3447ce3c953f22f2d8f495de692a
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/243/diff/
Testing
-------
Thanks,
Nils Philippsen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/241/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
If we disable the units before we call stop(), then the RequiredBy
linkage is already removed. This means that any unit that should
be controlled by the role-*.target won't actually be sent the
stop() command.
The correct thing to do here is to stop the role unit first, then
disable it.
Diffs
-----
src/rolekit/server/rolebase.py e573f56ae52a3447ce3c953f22f2d8f495de692a
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/241/diff/
Testing
-------
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/239/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Reviewed at https://reviewboard-fedoraserver.rhcloud.com/r/239/
Diffs
-----
doc/xml/Makefile.am 7f74173fa942c3b42c549b855550726404dd6fdd
doc/xml/rolekit.roles.custom.xml PRE-CREATION
doc/xml/seealso.xml 111208b3a4878c9433d7cc5b0112b50612a088ff
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/239/diff/
Testing
-------
Made a small custom role, deployed and decommissioned it.
Thanks,
Nils Philippsen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/242/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
This is an experimental domain controller role that uses a Docker
container rather than local RPMs.
Diffs
-----
config/Makefile.am d2e4106295a04d816b9148685569dea6ab93b44e
config/roles/domaincontroller-container/role.py PRE-CREATION
config/roles/memcache/role.py 20408e115d6653f52f88e784a775c70b92d72845
rolekit.spec e90eebd33d49d225a40d26db9bd9e36d49e1f97b
src/Makefile.am 34c6c042dedc0abc28d28b1cfe69e119c0ce6618
src/rolekit/server/io/docker.py PRE-CREATION
src/rolekit/server/io/systemd.py 7efe1531a0de82a045a6826e34ddc76654a8733b
src/rolekit/server/rolebase.py e573f56ae52a3447ce3c953f22f2d8f495de692a
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/242/diff/
Testing
-------
Deployed and removed several domain controllers.
Thanks,
Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/236/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
This pollutes environments when switching users and can cause error
messages like "-bash: __git_ps1: command not found".
Reviewed at https://reviewboard-fedoraserver.rhcloud.com/r/236/
Diffs
-----
contrib/vagrant/rolekitdev-bootstrap.sh 43f374b9f6ddff22b7f80c6abd18ce1425bae125
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/236/diff/
Testing
-------
Thanks,
Nils Philippsen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/237/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Reviewed at https://reviewboard-fedoraserver.rhcloud.com/r/237/
Diffs
-----
doc/xml/rolekit.roles.xml 8fd9ecc03be9fa7011bfa5511d64a22ddc8d727b
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/237/diff/
Testing
-------
Thanks,
Nils Philippsen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/238/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Reviewed at https://reviewboard-fedoraserver.rhcloud.com/r/238/
Diffs
-----
doc/xml/transform-man.xsl.in 778d0d0b31b687d4d2de7ef51e3e5bdc0335df32
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/238/diff/
Testing
-------
Thanks,
Nils Philippsen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/235/
-----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
-------
Fedora 23 has docker version 1.9.1 now, we don't need to install and
start 1.7.0 once then update anymore.
This partially reverts commit d6ec2518ee346e45d130b78ebf18f44ebcff513b.
Reviewed at https://reviewboard-fedoraserver.rhcloud.com/r/235/
Diffs
-----
contrib/vagrant/rolekitdev-bootstrap.sh 43f374b9f6ddff22b7f80c6abd18ce1425bae125
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/235/diff/
Testing
-------
Thanks,
Nils Philippsen