----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/127/#review379 -----------------------------------------------------------
src/rolekit/async.py http://reviewboard-fedoraserver.rhcloud.com/r/127/#comment209
I still think this function is entirely redundant and simply saying preexec_fn = set_ids (not set_ids()) would work, but I can’t provide a tested alternative patch, so… meh.
src/rolekit/async.py http://reviewboard-fedoraserver.rhcloud.com/r/127/#comment210
The parentheses are not idiomatic. Not a blocker obviously ?
tests/async_test.py http://reviewboard-fedoraserver.rhcloud.com/r/127/#comment211
This could be generalized to replace __run_bash_commands_async(with a stdin=None optional parameter), but this works just as well.
- Miloslav Trmac
On Úno. 17, 2015, 7:57 odp., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/127/
(Updated Úno. 17, 2015, 7:57 odp.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Add utility routine for passing stdin into subprocesses
Diffs
src/rolekit/async.py 0f9ddaac1beb27cebdf41ca0383a62a807c4fcb6 tests/async_test.py 12a4c12c8dbf427a6382c9bc82139bf246b08c37
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/127/diff/
Testing
Thanks,
Stephen Gallagher