----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/125/#review360 -----------------------------------------------------------
Ship it!
Ship It!
- Thomas Woerner
On Nov. 21, 2014, 5:02 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/125/
(Updated Nov. 21, 2014, 5:02 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Bugs: 34 https://fedorahosted.org/rolekit/ticket/34
Repository: rolekit
Description
We apparently missed restart() when handling the start() and stop() operations as asynchronous.
Diffs
src/rolekit/server/rolebase.py 7f960bf41206c2552996936839a100325382e3be
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/125/diff/
Testing
Built it and verified that the restart actually succeeded instead of returning a python error.
Thanks,
Stephen Gallagher