On Jan. 21, 2015, 4:39 p.m., Miloslav Trmac wrote:
src/rolekit/async.py, lines 291-292 http://reviewboard-fedoraserver.rhcloud.com/r/131/diff/2/?file=525#file525line291
This is now redundant with the check at line 299.
Hmm, I remember removing that; maybe I missed it when I rebased after dropping the stdin patch. Fixed.
- Stephen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/131/#review370 -----------------------------------------------------------
On Jan. 21, 2015, 3:49 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/131/
(Updated Jan. 21, 2015, 3:49 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Allow impersonating a different UID/GID in subprocesses
Diffs
src/rolekit/async.py 0f9ddaac1beb27cebdf41ca0383a62a807c4fcb6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/131/diff/
Testing
Thanks,
Stephen Gallagher