On Jan. 20, 2015, 7:48 p.m., Miloslav Trmac wrote:
src/rolekit/async.py, line 294 http://reviewboard-fedoraserver.rhcloud.com/r/131/diff/1/?file=524#file524line294
AFAICS _calling_ the demote() function is superfluous and, to me, confusing; we only need to pass the set_ids callable.
I actually looked up how to do this in several places and all the examples I could find insisted that it had to be done this way or else the calling application would also be affected by the permission drop. I'm choosing to trust them.
On Jan. 20, 2015, 7:48 p.m., Miloslav Trmac wrote:
src/rolekit/async.py, lines 298-299 http://reviewboard-fedoraserver.rhcloud.com/r/131/diff/1/?file=524#file524line298
setre[ug]id() to make it explicit that both are changed?
Seems excessive, but ok, sure.
- Stephen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/131/#review364 -----------------------------------------------------------
On Jan. 20, 2015, 6:12 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/131/
(Updated Jan. 20, 2015, 6:12 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Allow impersonating a different UID/GID in subprocesses
Diffs
src/rolekit/async.py 0f9ddaac1beb27cebdf41ca0383a62a807c4fcb6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/131/diff/
Testing
Thanks,
Stephen Gallagher