----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/127/#review363 -----------------------------------------------------------
src/rolekit/util.py http://reviewboard-fedoraserver.rhcloud.com/r/127/#comment191
Per documentation, "except that data is spooled in memory until the file size exceeds max_size, _or until the file’s fileno() method is called_, at which point the contents are written to disk and operation proceeds as with TemporaryFile()".
subprocess does call fileno(), so the data will end up on disk.
I suppose it would be ideally clean to use a pipe instead and write data to it similarly to the way we collect output, but that’s also much more work…
*shrug* This works as well.
- Miloslav Trmac
On Led. 20, 2015, 6:58 odp., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/127/
(Updated Led. 20, 2015, 6:58 odp.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
Add utility routine for passing stdin into subprocesses
Diffs
src/rolekit/util.py PRE-CREATION src/rolekit/async.py 0f9ddaac1beb27cebdf41ca0383a62a807c4fcb6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/127/diff/
Testing
Thanks,
Stephen Gallagher