-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/231/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 1:22 a.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.
Changes
-------
Revert the change to use `dict` initialization. This broke the patch completely. The
RawConfigParser presents a dict-like interface, but it cannot actually be initialized
properly with a dictionary. (The result was that the `tuple` values were actually saved as
a string of their `repr()` representation.
So this patch reverts to my original (and IMHO more readable) implementation.
Repository: rolekit
Description
-------
We no longer require the failure unit or the extension units. Now
that we are getting the state from systemd directly, we will simply
set up the Requires/RequiredBy/BindsTo settings appropriately so
that rolekit and systemd are always kept in sync.
Diffs (updated)
-----
config/roles/databaseserver/role.py 1af90551aff0f681ee8c2f787780e76f24330927
config/roles/domaincontroller/role.py 9fefd60aed47888d2e7884a4b70a6ad76dd104d8
config/roles/memcache/role.py d12974128a75ef38666bbdd7d70b7623631e3166
config/roles/testrole/role.py b5fda8dc92b42735a7b0ce5c6b21fed7cf6fd015
src/rolekit/server/io/systemd.py b105483c7fa689a43a960ef78aa1105f7aa58b42
src/rolekit/server/rolebase.py 510190a5fbd66858417e9f75f73ded63e6236b85
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/231/diff/
Testing
-------
Thanks,
Stephen Gallagher