On Oct. 14, 2014, 2:16 a.m., Stephen Gallagher wrote:
> Ship It!
Pushed:
https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=146b48f9e35ed78e...
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/91/#review303
-----------------------------------------------------------
On Oct. 14, 2014, 8:10 a.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/91/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 8:10 a.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
The following command will notify roled that there is could be an error:
dbus-send --system --dest=org.fedoraproject.rolekit1 \
/org/fedoraproject/rolekit1 \
org.fedoraproject.rolekit1.NotifyUnitFailed? \
string:'rolename' \
string:'instancename'
roled verifies if there is an error by getting the state from the unit target and moves
the instance into error state in this case.
Also fixes the dbus-send call to use the --system option. Otherwise the session bus will
be used.
New target_unit_state in dbus_utils to get the state form a target unit.
Diffs
-----
src/rolekit/dbus_utils.py 38aede076ca9c510c9c5853acfb11ec7673dbf06
src/rolekit/server/io/systemd.py 28b2591b21467eb0bd91483a610cbb7a592a4b27
src/rolekit/server/rolebase.py 909fdf5151820e09843ae3eb54a40ff7f0c03233
src/rolekit/server/roled.py 664c2873e8cc9c181c28806cfbc0d44d285b3693
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/91/diff/
Testing
-------
Thanks,
Thomas Woerner