Review Request 171: rolectl: Automatically stop services when decommissioning

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/171/
-----------------------------------------------------------

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

Prior to this, if the service was still running, we would get an
error telling us that the service couldn't be decommissioned
unless it was in the "ready-to-start" or "error" state.

Fixes https://github.com/libre-server/rolekit/issues/23


Diffs
-----

  src/rolectl dd2d41cd6d5086d61ee056e9a6b99d84fb605185 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/171/diff/


Testing
-------

Decommissioned the memcache role while it was still running.


Thanks,

Stephen Gallagher

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/171/#review449
-----------------------------------------------------------



src/rolectl (line 309)
<http://reviewboard-fedoraserver.rhcloud.com/r/171/#comment258>

    Please add a comment here that the instance will be stopped.


- Thomas Woerner


On July 30, 2015, 5:54 p.m., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/171/
>  -----------------------------------------------------------
>  
>  (Updated July 30, 2015, 5:54 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  Prior to this, if the service was still running, we would get an
>  error telling us that the service couldn't be decommissioned
>  unless it was in the "ready-to-start" or "error" state.
>  
>  Fixes https://github.com/libre-server/rolekit/issues/23
>  
>  
>  Diffs
>  -----
>  
>    src/rolectl dd2d41cd6d5086d61ee056e9a6b99d84fb605185 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/171/diff/
>  
>  
>  Testing
>  -------
>  
>  Decommissioned the memcache role while it was still running.
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/171/
-----------------------------------------------------------

(Updated Aug. 3, 2015, 2:45 p.m.)


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Changes
-------

Added a print statement indicating that services were being stopped.


Repository: rolekit


Description
-------

Prior to this, if the service was still running, we would get an
error telling us that the service couldn't be decommissioned
unless it was in the "ready-to-start" or "error" state.

Fixes https://github.com/libre-server/rolekit/issues/23


Diffs (updated)
-----

  src/rolectl dd2d41cd6d5086d61ee056e9a6b99d84fb605185 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/171/diff/


Testing
-------

Decommissioned the memcache role while it was still running.


Thanks,

Stephen Gallagher

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/171/
-----------------------------------------------------------

(Updated Aug. 3, 2015, 2:47 p.m.)


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Changes
-------

Fix bad previous 'rbt post'. I forgot to rebase first.


Repository: rolekit


Description
-------

Prior to this, if the service was still running, we would get an
error telling us that the service couldn't be decommissioned
unless it was in the "ready-to-start" or "error" state.

Fixes https://github.com/libre-server/rolekit/issues/23


Diffs (updated)
-----

  src/rolectl 9a3fb9e9236c3adf7552b6003a25af9a2488a3da 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/171/diff/


Testing
-------

Decommissioned the memcache role while it was still running.


Thanks,

Stephen Gallagher

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/171/#review450
-----------------------------------------------------------

Ship it!


Looks good to me, and seems to work.

- Nils Philippsen


On Aug. 3, 2015, 4:47 nachm., Stephen Gallagher wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/171/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 3, 2015, 4:47 nachm.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  Prior to this, if the service was still running, we would get an
>  error telling us that the service couldn't be decommissioned
>  unless it was in the "ready-to-start" or "error" state.
>  
>  Fixes https://github.com/libre-server/rolekit/issues/23
>  
>  
>  Diffs
>  -----
>  
>    src/rolectl 9a3fb9e9236c3adf7552b6003a25af9a2488a3da 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/171/diff/
>  
>  
>  Testing
>  -------
>  
>  Decommissioned the memcache role while it was still running.
>  
>  
>  Thanks,
>  
>  Stephen Gallagher
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/171/
-----------------------------------------------------------

(Updated Aug. 3, 2015, 4:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

Prior to this, if the service was still running, we would get an
error telling us that the service couldn't be decommissioned
unless it was in the "ready-to-start" or "error" state.

Fixes https://github.com/libre-server/rolekit/issues/23


Diffs
-----

  src/rolectl 9a3fb9e9236c3adf7552b6003a25af9a2488a3da 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/171/diff/


Testing
-------

Decommissioned the memcache role while it was still running.


Thanks,

Stephen Gallagher