On Oct. 12, 2014, 11:22 p.m., Stephen Gallagher wrote:
> src/rolekit/server/rolebase.py, lines 565-577
>
<
http://reviewboard-fedoraserver.rhcloud.com/r/89/diff/1/?file=413#file413...
>
> There's no reason to run groupinstall separately. Modern yum (including RHEL
7) will accept @groupname properly at the 'yum install' command, not just the
'yum groupinstall' command. It would be best if we ran only a single transaction
here.
I've made the changes I identified in this comment and pushed it to my public github
repo at
https://github.com/sgallagher/rolekit/commit/b01b67a72951f8c53d8ca2ebe757...
(Review Board doesn't let me update this review, since I didn't create it). I
tested it with the Domain Controller role and it worked properly, installing all the
necessary packages and then deploying. If you agree with my changes, go ahead and push
it.
- Stephen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/89/#review293
-----------------------------------------------------------
On Oct. 11, 2014, 11:24 a.m., Thomas Woerner wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/89/
-----------------------------------------------------------
(Updated Oct. 11, 2014, 11:24 a.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas
Woerner.
Repository: rolekit
Description
-------
New package and group installation during role deployment
Diffs
-----
config/roles/testrole/role.py 368e5d977d249042dbe453b9a636c24a93df6f55
src/rolekit/server/rolebase.py f9596e0bf15840d21869d434ae45ffa00dc53632
Diff:
http://reviewboard-fedoraserver.rhcloud.com/r/89/diff/
Testing
-------
Thanks,
Thomas Woerner