Review Request 215: remove 'pass' statements from non-empty blocks

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/215/
-----------------------------------------------------------

Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

remove 'pass' statements from non-empty blocks


Diffs
-----

  config/roles/domaincontroller/role.py f7536dcd811edc1c4c0d2c97ef194030b07d1bed 
  doc/xml/rolekit.roles.xml 9805fbc30f9ba9a0aee6a77474d999094c6cf419 
  src/rolekit/server/dbusrole.py f751b2e00df1a81856906f9452ac018f06348fca 
  src/rolekit/server/io/systemd.py 317c589109a382d180b1a457fa1c0ed633ec73bc 
  src/rolekit/server/rolebase.py 55add0077016c92eff2c9699b13e5c7d6026e574 
  tests/async_test.py 6348da8d81afa0073f7f762691c9f1bc5f248526 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/215/diff/


Testing
-------


Thanks,

Nils Philippsen

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/215/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 5:47 nachm.)


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

remove 'pass' statements from non-empty blocks


Diffs (updated)
-----

  config/roles/domaincontroller/role.py f7536dcd811edc1c4c0d2c97ef194030b07d1bed 
  doc/xml/rolekit.roles.xml 9805fbc30f9ba9a0aee6a77474d999094c6cf419 
  src/rolekit/server/dbusrole.py c0e69defc3e1a61a682efba536858186d0655e57 
  src/rolekit/server/io/systemd.py 317c589109a382d180b1a457fa1c0ed633ec73bc 
  src/rolekit/server/rolebase.py d7063c0069ae03d86c75286290780d3d1cda772a 
  tests/async_test.py 6348da8d81afa0073f7f762691c9f1bc5f248526 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/215/diff/


Testing
-------


Thanks,

Nils Philippsen

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/215/#review527
-----------------------------------------------------------


Please rebase this atop the latest master. It doesn't apply cleanly after the log
changes.

- Stephen Gallagher


On Sept. 15, 2015, 3:47 p.m., Nils Philippsen wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/215/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 15, 2015, 3:47 p.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  remove 'pass' statements from non-empty blocks
>  
>  
>  Diffs
>  -----
>  
>    config/roles/domaincontroller/role.py f7536dcd811edc1c4c0d2c97ef194030b07d1bed 
>    doc/xml/rolekit.roles.xml 9805fbc30f9ba9a0aee6a77474d999094c6cf419 
>    src/rolekit/server/dbusrole.py c0e69defc3e1a61a682efba536858186d0655e57 
>    src/rolekit/server/io/systemd.py 317c589109a382d180b1a457fa1c0ed633ec73bc 
>    src/rolekit/server/rolebase.py d7063c0069ae03d86c75286290780d3d1cda772a 
>    tests/async_test.py 6348da8d81afa0073f7f762691c9f1bc5f248526 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/215/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Nils Philippsen
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/215/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 1:37 nachm.)


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

remove 'pass' statements from non-empty blocks


Diffs (updated)
-----

  config/roles/domaincontroller/role.py 3ff5c85678c71e27859d1eb778fc81cf49ca756b 
  doc/xml/rolekit.roles.xml 9805fbc30f9ba9a0aee6a77474d999094c6cf419 
  src/rolekit/server/dbusrole.py ab65993ead34b2000b1f8150116d9782128ced0f 
  src/rolekit/server/io/systemd.py 317c589109a382d180b1a457fa1c0ed633ec73bc 
  src/rolekit/server/rolebase.py 1dc1d2386183838d6ab23853baed7e8b96a13b3c 
  tests/async_test.py 6348da8d81afa0073f7f762691c9f1bc5f248526 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/215/diff/


Testing
-------


Thanks,

Nils Philippsen

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/215/#review531
-----------------------------------------------------------

Ship it!


Ship It!

- Stephen Gallagher


On Sept. 16, 2015, 11:37 a.m., Nils Philippsen wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-fedoraserver.rhcloud.com/r/215/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 16, 2015, 11:37 a.m.)
>  
>  
>  Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
> Gallagher, and Thomas Woerner.
>  
>  
>  Repository: rolekit
>  
>  
>  Description
>  -------
>  
>  remove 'pass' statements from non-empty blocks
>  
>  
>  Diffs
>  -----
>  
>    config/roles/domaincontroller/role.py 3ff5c85678c71e27859d1eb778fc81cf49ca756b 
>    doc/xml/rolekit.roles.xml 9805fbc30f9ba9a0aee6a77474d999094c6cf419 
>    src/rolekit/server/dbusrole.py ab65993ead34b2000b1f8150116d9782128ced0f 
>    src/rolekit/server/io/systemd.py 317c589109a382d180b1a457fa1c0ed633ec73bc 
>    src/rolekit/server/rolebase.py 1dc1d2386183838d6ab23853baed7e8b96a13b3c 
>    tests/async_test.py 6348da8d81afa0073f7f762691c9f1bc5f248526 
>  
>  Diff: http://reviewboard-fedoraserver.rhcloud.com/r/215/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Nils Philippsen
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-fedoraserver.rhcloud.com/r/215/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 12:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for RoleKit Mailing List, Miloslav Trmac, Nils Philippsen, Stephen
Gallagher, and Thomas Woerner.


Repository: rolekit


Description
-------

remove 'pass' statements from non-empty blocks


Diffs
-----

  config/roles/domaincontroller/role.py 3ff5c85678c71e27859d1eb778fc81cf49ca756b 
  doc/xml/rolekit.roles.xml 9805fbc30f9ba9a0aee6a77474d999094c6cf419 
  src/rolekit/server/dbusrole.py ab65993ead34b2000b1f8150116d9782128ced0f 
  src/rolekit/server/io/systemd.py 317c589109a382d180b1a457fa1c0ed633ec73bc 
  src/rolekit/server/rolebase.py 1dc1d2386183838d6ab23853baed7e8b96a13b3c 
  tests/async_test.py 6348da8d81afa0073f7f762691c9f1bc5f248526 

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/215/diff/


Testing
-------


Thanks,

Nils Philippsen