[PATCH] Requires python, python-lxml in spec file

[Mike Palmiotto]

The python-lxml module is needed to make scap-security-guide.

Michael Palmiotto (1):
  Make SSG require python and python-lxml

scap-security-guide.spec |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

[PATCH] Make SSG require python and python-lxml

[Mike Palmiotto]

Signed-off-by: Michael Palmiotto 
---
 scap-security-guide.spec |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/scap-security-guide.spec b/scap-security-guide.spec
index 55e22a5..4977d9a 100644
--- a/scap-security-guide.spec
+++ b/scap-security-guide.spec
@@ -13,7 +13,7 @@ BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
 BuildArch:	%{arch}

BuildRequires:  /bin/rm, /bin/mkdir, /bin/cp
-Requires:       /bin/bash, /bin/date, /usr/bin/oscap
+Requires:       /bin/bash, /bin/date, /usr/bin/oscap, python, python-lxml

%description
 The scap-security-guide project provides security configuration guidance in
@@ -47,6 +47,9 @@ rm -rf $RPM_BUILD_ROOT

%changelog
+* Fri Jul 13 2012 Mike Palmiotto  1.0-4
+- Now requires python and python-lxml
+
 * Wed Jul 3 2012 Jeffrey Blank  1.0-3
 - Modified install section, made description more concise.

[PATCH] Make SSG require python and python-lxml

[Jeffrey Blank]

Thanks for bringing this up; it didn't seem complete to me at the time,
but was a non-blocking detail.

That said, should those really be for the BuildRequires?

The RPM really just delivers some (ready-to-use) XCCDF and OVAL and some
guidance/tables (in HTML), and so I assumed that it should be good to go
if it's got oscap (to process it).  And technically, somebody could use
some other tool to run an evaluation of the system (if they really
wanted to).

I haven't looked at the RPM documentation to know what's what here, but
if you could, that would be great.

When I re-worked the specfile from the original one, I definitely caused
python and python-lxml to be required for a build.

On 07/13/2012 10:47 AM, Michael Palmiotto wrote:
> Signed-off-by: Michael Palmiotto
>
> scap-security-guide.spec |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/scap-security-guide.spec b/scap-security-guide.spec
> index 55e22a5..4977d9a 100644
> --- a/scap-security-guide.spec
> +++ b/scap-security-guide.spec
> @@ -13,7 +13,7 @@ BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
>  BuildArch:	%{arch}
>
> BuildRequires:  /bin/rm, /bin/mkdir, /bin/cp
> -Requires:       /bin/bash, /bin/date, /usr/bin/oscap
> +Requires:       /bin/bash, /bin/date, /usr/bin/oscap, python, python-lxml
>
> %description
>  The scap-security-guide project provides security configuration guidance in
> @@ -47,6 +47,9 @@ rm -rf $RPM_BUILD_ROOT
>
> %changelog
> +* Fri Jul 13 2012 Mike Palmiotto  1.0-4
> +- Now requires python and python-lxml
> Wed Jul 3 2012 Jeffrey Blank  1.0-3
> Modified install section, made description more concise.

[PATCH] Make SSG require python and python-lxml

[Mike Palmiotto]

> The RPM really just delivers some (ready-to-use) XCCDF and OVAL and some
> guidance/tables (in HTML), and so I assumed that it should be good to go
> if it's got oscap (to process it).  And technically, somebody could use
> some other tool to run an evaluation of the system (if they really
> wanted to).

Forgive me, I did not see the output directory files rolled into the RPM and 
panicked.  I was expecting the xccdf/oval to be generated in output/, I now
realize it is in content/.

--Mike