sssd-devel August 2009

sssd-devel@lists.fedorahosted.org

11 participants
80 discussions

[PATCH] fix internal order of ldap user mapping options
by Sumit Bose 28 Aug '09

28 Aug '09

Hi, a previous patch added a new attribute and also changed the internal order of the existing attributes. This patch changes the numbering of the attributes to match the new order. bye, Sumit

2 1

[PATCH] send SSSD_REALM and SSSD_KDCIP environment to the client
by Sumit Bose 28 Aug '09

28 Aug '09

Hi, the environment variable which are send back by this patch are currently needed in the user session of the client. When the DNS helper is available and used by the kerberos locator plugin they can be removed. bye, Sumit

2 2

[PATCH] Speed up NSS enumeration code
by Simo Sorce 28 Aug '09

28 Aug '09

This patch should make the enumeration code ~ O(log n) instead of O(n) On my system it brought enumeration down from 12s to 4s with the same data set. Simo. -- Simo Sorce * Red Hat, Inc * New York

2 2

Re: [SSSD] [Freeipa-devel] [PATCH] add configure check for errno_t
by Sumit Bose 28 Aug '09

28 Aug '09

On Mon, Jul 27, 2009 at 09:53:23AM -0400, Stephen Gallagher wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 07/24/2009 05:05 PM, Sumit Bose wrote: > > Hi, > > > > we regular use functions returning errno error code like ENOMEN or > > EINVAL. The return type of these functions is usually int. To underline > > that the return code is only an error code and should not be used > > otherwise a special type can be used. There is the ISO/ICE technical > > report 24731-1 which recommends they type errno_t for this purpose. I > > think it makes sense to stick with this recommendation (and I hope > > people don't mind that the same TR also recommends the not so smart *_s > > replacements for most of the standard libc functions). > > > > The attached patch add a configure check for errno_t and defines it if > > not present in the system. > > > > bye, > > Sumit > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Freeipa-devel mailing list > > Freeipa-devel(a)redhat.com > > https://www.redhat.com/mailman/listinfo/freeipa-devel > > Nack. > > Please include a patch that modifies the configure scripts of the > sss_client and common directories. > I have include the check in the sss_client directory, but I'm reluctant to add it to common, too. IMO the maintainers of the packages should decide if errno_t makes sense for them or not. A second argument would be that in most cases there is no private header file where the typedef can be added. bye, Sumit

3 4

Some ELAPI design questions
by Dmitri Pal 27 Aug '09

27 Aug '09

Hi, I have some thoughts that I wanted to run by you. May be I am getting too deep and trying to overengineer things. And I am definitely a bit confused about what should I use in the specific case. When writing into the file via ELAPI I need to understand how to deal with: * async processing * buffering * streams and file descriptors The async processing means that we need to be able to prepare data to write and then indicate that we want it to be written but do not block. The actual writing happens from the main loop when the file dgot green light and we know that it would not block. Same with read. The async processing is all based on file descriptors as far as I have seen. When we talk about buffering there are different levels of buffering. There is kernel buffering and stdio stream buffering. Streams are more convenient to use plus I wanted to provide a sink that writes to stderr, but may be I should reconsider. So what is the problem? It seems that stdio and async processing should not be used together. Is this correct? Even if I get fileno() from the stream I write to and pass it to the library like tevent (or similar) the async processing will be screwed by streams buffering data. Is this correct understanding? Can I use stdio or should I use low level : open-write-fsync-close functions? There are "_unlocked" equivalents of some of the stdio functions but it is not clear if they will be available on other platforms. If I do not use stdio I will not take advantage of the stdio buffering. If I understand correctly in this case the fsync forces kernel to flush the page. Is this Ok? If I use stdio then I can potentially have one implementation for writing to file and to stderr. But here is another issue with using stdio and stderr in particular. The program that uses ELAPI can be a daemon which closes file decriptors 0-2. Using close(). In this case trying to use stderr would not do any good. So before using stderr I need to check fd 2 is still open and if it is not do something about it. The expectation and the goal is to effectively recover the stderr steam and be able to write to it so that output goes to the terminal. Here is the piece of code I have in mind: fd = fileno(stderr); err = fcntl(fd, F_GETFD) if (err != EBADF) { file descriptor is open so I can use stderr as is... } else { stderr is broken we need to rewive it. How? Would I have to create a file descriptor, attach it to terminal and then attach to stderr using fdopen(). Is there anything better? Is there anything that would help me to just output things to the terminal? } I am trying to understand the whole solution and have a consistent approach that deals with all these issues. And one more thing - keeping the file open, I suspect that by default the file should be kept open and we just need to flush it from time to time based on config parameter but there is also a need to allow "append" functionality when file is opened on per event basis. Though this is costly and inefficient to reopen it all the time (no doubts) there might be cases where such functionality is required. I guess I just close and re-open file in this case but async processing would mess things up a bit. You can't just enqueue data to be written and let the event library deal with it. The callback that would write my data to fd would have to complete writing one record and then close fd and open new fd, create a different event and attach next record to it. Something like this. Brain starts to boil a bit when I start thinking about chaining of these callbacks (IMO threads and semaphores are simpler :-)) -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. ------------------------------- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

2 1

[PATCHES] make enumerations a background task
by Simo Sorce 27 Aug '09

27 Aug '09

This affects only the ldap driver. Enumerations are now a background task, on startup a full enumeration is performed. Then every 5 minutes (changeable default) only new/modified entries are retrieved. So after the first full pull the quantity of data that is pulled is limited, this is why I have not removed the large transaction yet. Next step is to change the group handling code into a 2 step process, or some group membership may be lost against server that allow nested groups via the member/memberof schema. 0001 simplify code, no need for a wrapper 0002 The patch that changes the enumeration code Simo. -- Simo Sorce * Red Hat, Inc * New York

2 3

[PATCHES] remove "legacy" option
by Simo Sorce 27 Aug '09

27 Aug '09

The "legacy" option was introduced to speed up development. It is actually confusing and not necessary. >From now on we store all using the member/memberof schema internally. (Tested only with the native ldap driver). 0001 mainly converts the core sysdb functions 0002 fixes many errors in fill_grent and removes legacy support form there 0003 adds an upgrade function to convert existing databases on the first run. Simo. -- Simo Sorce * Red Hat, Inc * New York

3 4

[PATCH] Initial support for multiple schema types
by Simo Sorce 27 Aug '09

27 Aug '09

While this patch does not add much yet it is a prerequisite for the following ones I am going to send. It sets a paths I want to follow in allowing the ldap driver to handle servers with different schema types (for example use of memberUid vs member/memberOf). Simo. -- Simo Sorce * Red Hat, Inc * New York

2 2

[PATCH] do not show server messages to user
by Sumit Bose 27 Aug '09

27 Aug '09

Hi, with this patch the server messages indicating the reason of an authentication error are not displayed to the user anymore. But they are still send to syslog. Is there anything else which should be sent to syslog according to https://fedorahosted.org/sssd/ticket/32 ? Otherwise I would close the ticket. bye, Sumit

4 5

[PATCH] removed unused header file
by Sumit Bose 27 Aug '09

27 Aug '09

Hi, this patch removes an old and unused header file. bye, Sumit

3 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

sssd-devel August 2009