On (01/10/15 20:13), Jakub Hrozek wrote:
On Fri, Sep 25, 2015 at 07:49:23AM +0200, Lukas Slebodnik wrote:
> There is a common agreement (at least from management side) that we want
> to improve code coverage This patch is great opportunity to add regression
> test. You can choose either integration test or unit test; you should know
> what suits better to this case.
I tried to create a test (see my tests branch at fp.o) but it's really
not easy, the sdap_async.c module has quite some dependencies and the
generic search request is real pita to mock. And we need to apply this
patch to downstream.
So while I agree with you we need tests, I think this one needs to be
done together with the LDAP refactoring, sorry.
What about integration test?
LS