On Tue, Nov 18, 2014 at 02:56:35PM +0100, Jakub Hrozek wrote:
On Mon, Nov 17, 2014 at 06:35:57PM +0100, Sumit Bose wrote:
> On Fri, Nov 14, 2014 at 01:52:20PM +0100, Jakub Hrozek wrote:
> > On Thu, Nov 13, 2014 at 07:30:41PM +0100, Jakub Hrozek wrote:
> > > On Wed, Nov 12, 2014 at 05:08:09PM +0100, Lukas Slebodnik wrote:
> > >
>
> ...
>
> > > Thank you, see the attached patches.
> >
> > I forgot to remove the extra find_uid.c from Makefile.am
>
> I only have minor comments, see below. I understand that most part of
> the patches are refactorings to make sure the related code is run with
> the right permissions. (See next mail for some additional suggestions).
>
> The ccache handling always was delicate, e.g. directory creation with
> DIR type and determine if FILE with _XXXXXX should be recreated or
> reused. I run couple to tests without an issue but I think only
> regression testing might give clarity here. So ACK from my side.
Thank you for testing. Lukas was kind enough to run all available tests
our QE has at their disposal related to Kerberos. I hope that raises the
confidence level a bit.
The attached patches fix all the issues you raised previously.
Thank you, ACK.
bye,
Sumit