[SSSD]Replace hexadecimal debug level code in log messages with a text tag
Hello all,
I would like to work on:
https://fedorahosted.org/sssd/ticket/2808
However, there are two different opinions.
Ticket description says:
........................
Currently a log message of SSSD like e.g.
# (Mon Jun 29 22:10:59 2015) [sssd[be[lab.runlevelone.lan]]]
[be_get_account_info] (0x0200): Got request for [0x1001][1][name=dlavu]
has the debug level given by '(0x0200)'. For the inexperienced reader it
is hard to see if the message indicates an error or is only some
informational messages.
It would be good to replace them which short text tags which better
indicates the character and severity of the message. E.g. something like
ERR_CRIT, INFO_DATA, TRACE_FUNC ...
-----
Jakub said:
One issue that I realized is that we might want to add the string
representation in addition to hexa to avoid breaking existing scripts.
But on the other hand, I'm not sure if we should care too much about
keeping compatibility of debug logs...
And Lukas said:
I use very often hexadecimal representation for filtering huge log file.
So it should not be replaced. It's much simpler (and shorter) to write
regex for hexadecimal numbers.
-----
In my opinion, we should write numerical values if and only if they
represent values (uid for example), not enum constant.
In this situation I feel that filtering is important.
I suggest use:
# (Mon Jun 29 22:10:59 2015) [sssd[be[lab.runlevelone.lan]]]
[be_get_account_info] (0x0200 | INFO_FUNC_DATA): Got request for
[0x1001][1][name=dlavu]
What is your opinion, please?
Regards
Petr