On Mon, 2012-12-03 at 23:34 +0100, Jakub Hrozek wrote:
From af555ccfa228ea931d1eb31cc1dedd6f6d3580ce Mon Sep 17 00:00:00
2001
From: Jakub Hrozek <jhrozek(a)redhat.com>
Date: Mon, 26 Nov 2012 13:18:59 +0100
Subject: [PATCH 1/4] MEMBEROF: split processing the member modify into
a
separate function
- /* if we need to add something put it away so that it
- * can be done after all delete operations are over */
- if (added && added->num) {
- mod_ctx->to_add = added;
- }
-
- /* if we have something to remove do it first */
- if (removed && removed->num) {
- return mbof_mod_delete(mod_ctx, removed);
- }
-
- /* if there is nothing to remove and we have stuff to add
- * do it right away */
- if (mod_ctx->to_add) {
- return mbof_mod_add(mod_ctx, added);
- }
It seem like the above comments are lost in the new code, I would retain
them unless they do not apply anymore.
The rest looks good.
Simo.
--
Simo Sorce * Red Hat, Inc * New York