Simo Sorce wrote:
On Wed, 2009-09-09 at 13:33 -0400, Stephen Gallagher wrote:
> Patch 0001: Ensure that daemonization happens after reading in the
> configuration, so critical configuration errors repord "FAILED" during
> init script startup.
>
Nack, monitor_process_init() performs a number of operations (like
forking children) that assumes we are operating in the final monitor
process.
Moving become_daemon() after it would make these children loose, and
might interfere with other things like signal handlers etc.
In general I don't think we should do this.
May be instead the children should return a special "invalid config"
status via sbus when monitor connects to them first time?
This would tell monitor to shut down the whole family. What do you think?
> Patch 0002: Ensure that the minId and maxId values are sensible
(minId
>
>> maxId, neither < 0)
>>
ack this one.
Simo.
--
Thank you,
Dmitri Pal
Engineering Manager IPA project,
Red Hat Inc.
-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/