Re: [SSSD] [PATCHES] Fixes for sysdb_domain_init_internal()
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/14/2011 07:46 PM, Stephen Gallagher wrote:
On 04/14/2011 12:36 PM, Jakub Hrozek wrote:
> On Wed, Apr 13, 2011 at 04:19:36PM -0400, Stephen Gallagher wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Patch 0001: Don't leak memory if sysdb_domain_init() fails
>> This patch ensures we clean up the memory for the sysdb_ctx if we exit
>> on failure.
>>
> Needs a rebase (3-way merge was sufficient for me) on top of Simo's recent
> cleanup patch. Also we're still leaking memory if sysdb_get_db_file() fails.
>> Patch 0002: Run all appropriate upgrades
>> Previously, if we were upgrading from version 0.4 or older, we
>> would only run sysdb_upgrade_04() and exit, instead of also
>> running sysdb_upgrade_05().
>>
> Needs a rebase, too, but otherwise looks OK to me.
>> Patch 0003: Reopen the LDB after modifying it
>> If we change any of the special entries such as indexes or plugins,
>> we need to close and reopen the LDB to ensure that they take effect.
>>
>>
> Ack
>> Note: Patch 0003 was still safe in the SSSD daemon right now, as we
>> always pre-create the sysdb caches in the monitor and close it before
>> the backends start, but it was causing some trouble with the tests if we
>> were only running a subset that required memberOf.
Patches rebased and the memory leak mentioned in the review of Patch
0001 has been corrected. Thank you for the review.
Ack to all three patches.
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk2oAoYACgkQHsardTLnvCX5YQCeKGxjgnZPPAbOgZHoswCtLuHK
51cAnjwXk2qNub4f3OdoAwbe4cAcFoOV
=YIJG
-----END PGP SIGNATURE-----