On 07/08/2014 07:31 PM, Jakub Hrozek wrote:
On Tue, Jul 08, 2014 at 04:23:37PM +0200, Michal Židek wrote:
>> [PATCH 6/7] SDAP: Remove unused function sdap_get_msg_dn
>> This function was unused since 2009
>>
>
> Could you also remove the comment.
> /* =Get-DN-from-message==============
Done.
Ack.
>
>> [PATCH 7/7] SDAP: Free bervals on failure in sdap_parse_entry
>> I wasn't able to test this patch, so review would only be with visual
>> inspection, I think..
>>
>
> I think the ldap_value_free_len call should be here as well
> to free the memory allocated for the one NULL pointer:
> 447 } else {
> 448 if (!vals[0]) {
> 449 DEBUG(SSSDBG_CRIT_FAILURE,
> 450 "Missing value after ldap_get_values()
> ??\n");
> 451 ret = EINVAL;
> 452 goto done;
> 453 }
Thanks, nice catch.
Ack.