Re: [SSSD] Tool for querying SSSD database

[Dmitri Pal]

On 04/29/2013 09:18 AM, David Bambušek wrote:
> Thanks for comment
> corrected, thanks for noticing
> that ">" is not displayed on the real output, I just put it into
>
> text so it is clear what is the output, but you are right that it
> looks weird, so I removed it
> 3,4)  you can use just one of them, otherwise it is an error. I added
> a section where all the errors are enumerated

I noticed you have multiple formatting issues in the newly added errors
section. The section seems OK from the contents POW.
> I might add a section on this topic, thanks for recommendation
>
> Actualized version attached...
>
> David
>
> 2013/4/24 Dmitri Pal <[e-mail] >
> On 04/23/2013 05:35 PM, David Bambušek wrote:
> > Hello all agian,
> > I am attaching text of my bachelor work, if anyone of you would
> > be interested in reading it and giving any comments or
> > recommendations, I would be just glad. First chapters will
> > probably not be very interesting for you, so in case you are
> > gonna read it, just skip to chapter about SSSD and read further.
> I scanned through it pretty quickly.
> 1) There is a typo on page 28 "autofsm maps"
> 2) I am not sure I like ">" at the beginning of the output
> 3) What is the result when the -N and -uid are provided at the
> same time and they do not match? Who wins? Or it is an error?
> 4) In general having something on return codes, errors, logging
> would be beneficial
> 5) What about the permissions and SELinux? Anything should be
> done/described there?
>
> Thanks
> Dmitri
>
>
> > Best regards
> > David
> >
> >
> > 2013/4/22 David Bambušek <[e-mail]
> > <mailto:[e-mail]>>
> >
> >     I have made some final changes:
> >     - renamed those variables from upper case to lower case
> >     - used sss_hash_xxx function to create hash table, so there
> >     is less work with de-allocation now
> >     - I also included the intern name of sysdb attributes on
> >     output so now it looks like:
> >     <human_readable_attr> (<sysdb_attr>):      <value>
> >     GID Number (gidNumber):     0123456789
> >     - and finally there are no warnings during compilation
> >
> >     I squeezed all the commits into one and I made a patch, that
> >     is attached...
> >
> >
> >     2013/4/20 David Bambušek <[e-mail]
> >     <mailto:[e-mail]>>
> >
> >         Dne 19.4.2013 21:08, Jakub Hrozek napsal(a):
> >
> >             On Fri, Apr 19, 2013 at 02:13:21PM -0400, Simo Sorce
> >             wrote:
> >
> >                 On Tue, 2013-04-16 at 23:46 +0200, David Bambušek
> >                 wrote:
> >
> >                     So the newest version is already on my
> >                     github, with all the issues
> >                     mentioned above fixed.
> >
> >                 Can you please squash commits ?
> >
> >                 It is not interesting to see corrections and you
> >                 need to squash them in
> >                 reasonable patches for final submission anyway,
> >                 better do it often and
> >                 earlier IMO.
> >
> >             +1
> >
> >             It's worth noting that David stopped by the office
> >             when we had an Open
> >             House day this week and we went through the code in
> >             person. I think the
> >             tool mostly behaves good now, there are still some
> >             final touches needed,
> >             such as marking several strings as translatable and
> >             not naming variables
> >             in UPPERCASE even if they are static.
> >
> >             But the last iterations looked way better than the
> >             first ones,
> >             definitely a big improvement.
> >             _______________________________________________
> >             sssd-devel mailing list
> >             [e-mail]
> >             <mailto:[e-mail]>
> >             https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> >
> >         I hope I will be done with all the little things that
> >         need to be corrected by the end of this week. And sure, I
> >         will squash those commits ;)
> >
> >         David
> >
> >
> >
> >
> >
> > _______________________________________________
> > sssd-devel mailing list
> > [e-mail] <mailto:[e-mail]>
> > https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
> -- 
> Thank you,
> Dmitri Pal
>
> Sr. Engineering Manager for IdM portfolio
> Red Hat Inc.
>
>
> -------------------------------
> Looking to carve out IT costs?
> www.redhat.com/carveoutcosts/ <http://www.redhat.com/carveoutcosts/>
>
>
>
> _______________________________________________
> sssd-devel mailing list
> [e-mail]
> <mailto:[e-mail]>
> https://lists.fedorahosted.org/mailman/listinfo/sssd-devel