On Thu, Jul 02, 2015 at 03:06:57PM +0200, Pavel Reichl wrote:
Hello,
new round of patches is attached. I discussed the required changes with
Jakub to be sure we are on the same page as this thread is quite voluminous.
Basically I just made the setters/getters static and removed tests of this
functions. I hope that by this change we finally reached the desired level
of design quality.
Thanks!
PS: Feel free to ignore patch 3. It's just a by-product of this effort.
If you squash the extra line removal that Sumit noticed into Patch 3,
I'll ACK.
btw I'm still to test OTPs, but the single-factor authentication works.