On (22/07/15 11:43), Jakub Hrozek wrote:
On Mon, Jul 20, 2015 at 03:52:52PM +0200, Lukas Slebodnik wrote:
> On (20/07/15 15:46), Lukas Slebodnik wrote:
> >ehlo,
> >
> >attached is a regression test for old ticket 2163.
> >Currently it fails due to fix for ticket 2717
> >
> And now with attached patch.
>
> BTW I think that we should split fixtures
> and statiting sssd and loading data to LDAP should be two separate fixtures.
>
> LS
> From cd765024b9662eef537e1a84f1da23ce29173dcd Mon Sep 17 00:00:00 2001
> From: Lukas Slebodnik <lslebodn(a)redhat.com>
> Date: Mon, 20 Jul 2015 14:09:52 +0200
> Subject: [PATCH] intg_tests: Add regression test for 2163
>
> ---
> src/tests/intg/ldap_test.py | 40 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/src/tests/intg/ldap_test.py b/src/tests/intg/ldap_test.py
> index
afc77d7023ea31757def84f21e5d15997ba72013..914e0d0cc8680d73f0caed233965dfc537daf896 100644
> --- a/src/tests/intg/ldap_test.py
> +++ b/src/tests/intg/ldap_test.py
> @@ -141,6 +141,38 @@ def sanity_rfc2307(request, ldap_conn):
> create_sssd_fixture(request)
> return None
>
> +
> +(a)pytest.fixture
> +def simple_rfc2307(request, ldap_conn):
> + ent_list = ldap_ent.List(LDAP_BASE_DN)
> + ent_list.add_user('usr\\\\001', 181818, 181818)
> + ent_list.add_group("group1", 181818)
> +
> + create_ldap_fixture(request, ldap_conn, ent_list)
> +
> + conf = unindent("""\
> + [sssd]
> + config_file_version = 2
> + domains = LDAP
> + services = nss, pam
> +
> + [nss]
> +
> + [pam]
> +
> + [domain/LDAP]
> + ldap_auth_disable_tls_never_use_in_production = true
> + ldap_schema = rfc2307
> + id_provider = ldap
> + auth_provider = ldap
> + ldap_uri = {ldap_conn.ds_inst.ldap_url}
> + ldap_search_base = {ldap_conn.ds_inst.base_dn}
> + """).format(**locals())
> + create_conf_fixture(request, conf)
> + create_sssd_fixture(request)
> + return None
> +
> +
> @pytest.fixture
> def sanity_rfc2307_bis(request, ldap_conn):
> ent_list = ldap_ent.List(LDAP_BASE_DN)
> @@ -200,6 +232,14 @@ def sanity_rfc2307_bis(request, ldap_conn):
> create_sssd_fixture(request)
> return None
>
> +
> +def test_refression_ticket2163(ldap_conn, simple_rfc2307):
~~~~~~~~~~
typo: Should read regression.
Otherwise LGTM.
Updated patch is attached but it is still failing because bug is not fixed yet.
LS