On (14/07/15 15:18), Jakub Hrozek wrote:
>On Tue, Jul 14, 2015 at 02:39:13PM +0200, Pavel Březina wrote:
>> >>*Patch #02 SYSDB: Add functions to look up multiple entries including
name
>> >>and custom filter*
>> >>
>> >>>+static char *enum_filter(TALLOC_CTX *mem_ctx,
>> >>>+ const char *base_filter,
>> >>>+ const char *name_filter,
>> >>>+ const char *addtl_filter)
>> >>
>> >>You are leaking memory here if any of the allocation fails. I know it
will
>> >>be freed in the caller but it is not a good practice.
>> >
>> >As discussed on IRC, I added a context.
>>
>> Nack. You added a tmp_ctx but you still use mem_ctx :-)
>
>Let's try to again.
>
>This is the only change in the set.
>From 63574fbe77359ba1c84aac38dbbdf04053a69d92 Mon Sep 17 00:00:00 2001
>From: Jakub Hrozek <jhrozek(a)redhat.com>
>Date: Wed, 17 Jun 2015 16:13:51 +0200
>Subject: [PATCH 10/11] LDAP: Add the wildcard_limit option
>
>Related:
>
https://fedorahosted.org/sssd/ticket/2553
>
>Adds a new wildcard_limit option that is set by default to 1000 (one
>page). This option limits the number of entries that can by default be
>returned by a wildcard search.
>---
> src/config/SSSDConfig/__init__.py.in | 1 +
> src/config/etc/sssd.api.d/sssd-ad.conf | 1 +
> src/config/etc/sssd.api.d/sssd-ipa.conf | 1 +
> src/config/etc/sssd.api.d/sssd-ldap.conf | 1 +
> src/man/sssd-ldap.5.xml | 17 +++++++++++++++++
> src/providers/ad/ad_opts.h | 1 +
> src/providers/ipa/ipa_opts.h | 1 +
> src/providers/ldap/ldap_opts.h | 1 +
> src/providers/ldap/sdap.h | 1 +
> src/providers/ldap/sdap_async_groups.c | 8 +++++++-
> src/providers/ldap/sdap_async_users.c | 8 +++++++-
> 11 files changed, 39 insertions(+), 2 deletions(-)
>
I wanted to test my intigroups memory cache patches but I had to spent a time
with reviewving failed downstream tests.
git bisect claims that this patch caused a regression.
Please take a look into ticket
https://fedorahosted.org/sssd/ticket/2723
for more details.
LS
OK, I assigned the ticket to myself since I broke it.
Thanks for finding it.