Re: [SSSD] [PATCHES] Two minor fixes in LDAP provider
On Wed, Apr 18, 2012 at 07:38:13AM -0400, Stephen Gallagher wrote:
On Wed, 2012-04-18 at 12:14 +0200, Jakub Hrozek wrote:
> On Tue, Apr 17, 2012 at 03:23:33PM +0200, Jan Zeleny wrote:
> > #114:
> > There is no real issue in that code at this moment but it's only a lucky
> > coincidence. If there was another element in group_attrs before member, the
> > result would be SIGABRT.
> >
>
> The patch is correct but not as bad as it seems, the mem_ctx parameter is
> not used if the memory was previously allocated, only if ptr is NULL or
> size is 0 (but it seems the man page for talloc_realloc says otherwise..)
>
For the record, was that an ack?
Yes, Ack :-)