On (16/07/14 11:46), William wrote:
On Tue, 2014-07-15 at 15:57 +0200, Jan Cholasta wrote:
> On 11.7.2014 03:35, William wrote:
> >
> >>
> >> Thanks. Could you please rename the option to
> >> "entry_cache_ssh_host_timeout", so that it's consistent with
the rest of
> >> the cache timeout options?
> >>
> >>> However, I can't quite work out how to access confdb
> >>>> inside of ipa_hostid.c when it calls sysdb_store_ssh_host.
> >>
> >> I guess you can store the value in sss_domain_info, like the rest of the
> >> cache timeouts. See confdb_get_domain_internal.
> >>
> >
> >>>
> >>> Helps if I attach the patch.
> >>
> >> It certainly does :)
> >>
> >
> > Again, I have taken your advice and implemented these changes. I don't
> > see any dbus related changes in my patch, so I hope that this is too
> > your requirements.
>
> I do see some dbus changes: src/responder/ifp/ifp_iface_generated.c
>
> As Pavel and Lukáš pointed out earlier, these changes should not be
> included in the patch, as they are a result of a bug in dbus codegen script.
>
> >
> > Any comments and advice welcome.
>
> The confdb argument in sysdb_store_ssh_host is not needed anymore.
>
Ignore that last patch, I messed up and didn't include a .h file. Here
is the fixed patch.
I also rebased onto master, and I get:
/bin/sh ./libtool --tag=CC --mode=link gcc -Wall -Wshadow
-Wstrict-prototypes -Wpointer-arith -Wcast-qual -Wcast-align
-Wwrite-strings -Wundef -Werror-implicit-function-declaration
-Winit-self -fno-strict-aliasing -std=gnu99 -g -O2
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -module
-avoid-version
-Wl,--version-script,./src/sss_client/autofs/sss_autofs.exports -o
libsss_autofs.la -rpath /srv/sssd/lib/sssd/modules
src/sss_client/common.lo src/sss_client/autofs/sss_autofs.lo -lpthread
-ldl
libtool: link: gcc -shared -fPIC -DPIC src/sss_client/.libs/common.o
src/sss_client/autofs/.libs/sss_autofs.o -lpthread -ldl -O2
-Wl,--version-script -Wl,./src/sss_client/autofs/sss_autofs.exports
-Wl,-soname -Wl,libsss_autofs.so -o .libs/libsss_autofs.so
gcc: error: src/sss_client/.libs/common.o: No such file or directory
make[2]: *** [libsss_autofs.la] Error 1
make[2]: Leaving directory `/home/a1176360/development/sssd'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/a1176360/development/sssd'
make: *** [all] Error 2
Doesn't appear to be related to anything I have changed I don't
think ...
You forgot to change usage of sysdb_store_ssh_host in sysdb_ssh-tests.
tests cannot be compiled. (make check)
CC src/tests/sysdb_ssh_tests-sysdb_ssh-tests.o
src/tests/sysdb_ssh-tests.c:179:43: error: too few arguments to function call,
expected 6, have 5
data->attrs);
^
src/db/sysdb_ssh.h:32:1: note: 'sysdb_store_ssh_host' declared here
errno_t
^
1 error generated.
From 29cdcbd9a20cfbd72c5a8d103f58e3f153887d73 Mon Sep 17 00:00:00
2001
From: William B <william(a)adelaide.edu.au>
Date: Wed, 16 Jul 2014 11:45:02 +0930
Subject: [PATCH] Allow sss_cache tool to flush known hosts cache
---
src/confdb/confdb.h | 2 ++
src/config/etc/sssd.api.conf | 1 +
src/db/sysdb_ssh.c | 58 +++++++++++++++++++++++++++++++++++++++---
src/db/sysdb_ssh.h | 17 ++++++++++++-
src/man/po/sssd-docs.pot | 17 +++++++++++++
src/providers/ipa/ipa_hostid.c | 2 +-
src/tools/sss_cache.c | 54 +++++++++++++++++++++++++++++++++++----
7 files changed, 140 insertions(+), 11 deletions(-)
//snip
diff --git a/src/man/po/sssd-docs.pot b/src/man/po/sssd-docs.pot
index df0456d..a4fce38 100644
--- a/src/man/po/sssd-docs.pot
+++ b/src/man/po/sssd-docs.pot
@@ -1140,6 +1140,23 @@ msgstr ""
msgid "Default: 180"
msgstr ""
+#. type: Content of:
<reference><refentry><refsect1><refsect2><variablelist><varlistentry><term>
+#: sssd.conf.5.xml:878
+msgid "ssh_known_hosts_expire (integer)"
+msgstr ""
+
+#. type: Content of:
<reference><refentry><refsect1><refsect2><variablelist><varlistentry><listitem><para>
+#: sssd.conf.5.xml:881
+msgid ""
+"How many seconds to keep a host ssh key after refresh. IE how long to cache "
+"the host key for."
+msgstr ""
+
+#. type: Content of:
<reference><refentry><refsect1><refsect2><variablelist><varlistentry><listitem><para>
+#: sssd.conf.5.xml:885
+msgid "Default: 31536000 (1 Year)"
+msgstr ""
+
#. type: Content of:
<reference><refentry><refsect1><refsect2><title>
#: sssd.conf.5.xml:893
msgid "PAC responder configuration options"
We do not update pot files directly.
Could you edit xml file src/man/sssd.conf.5.xml ?
LS