-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/10/2013 08:23 AM, Jakub Hrozek wrote:
On Tue, Apr 09, 2013 at 12:13:44AM +0200, Jakub Hrozek wrote:
> On Tue, Apr 09, 2013 at 03:32:04AM +0530, Abhishek Singh wrote:
>> Hi Jakub,
>>
>> Please check this patch.
>>
>
> Ack with a one change I can do myself before pushing, no need to
> re-send:
>
> I would prefer if the get_filepath declaration didn't hardcode
> the array size, but rather looked like:
>
> static char *get_filepath(char path[])
>
> I think just stating that get_filepath() assumes that the buffer
> is big enough is OK for a unit test. But in real defensive code,
> I would prefer if the function had a second parameter to specify
> the size and allow checks on it.
>
> But as I said above, I'll fix the get_filepath declaration
> before pushing and then push.
>
> Thanks for the contribution!
Fixed the declaration and pushed to master.
Great job, Abhishek!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iEYEARECAAYFAlFlaLkACgkQeiVVYja6o6NsuwCfZlxifkAQoSWT4nop+zIN9F26
A6QAnjSMk+/3N+oNl8OKyjz1hrXoCihd
=6xwc
-----END PGP SIGNATURE-----