On 08/09/2012 02:26 PM, Jakub Hrozek wrote:
> On Thu, Aug 09, 2012 at 01:46:22PM +0200, Pavel Březina wrote:
>> On 08/09/2012 10:50 AM, Michal Zidek wrote:
>>> This patch solves 2 things mentioned in ticket 1463.
>>> a) If the same server is in both primary and secondary server list, we
>>> must only add it to the primary list.
>>>
>>> b) SRV resolution for backup servers should not be permitted. It now
>>> prints error message if the sssd.conf
>>> is configured that way.
>>>
>>>
https://fedorahosted.org/sssd/ticket/1463
>>>
>>> The patch is attached.
>>>
>>> Thanks
>>> Michal
>> Nack.
>> Duplicates are already handled in be_fo_add_server() and
>> be_fo_add_srv_server() so it does not require any changes. But you
>> can add a debug message that will inform about adding a duplicate.
> Thanks, it turns out that the duplicate detection is supposed to be
> handled by fo_server_match(), but it's not working, at least for LDAP
> URIs, because the "user_data" payload is different for both servers.
>
> That bug also doesn't hit only back up servers, but also duplicates in
> primary list do not work.
>
>> The srv part looks good.
> Michal, please split the SRV part from this patch, we should get it in
> soon because it changes strings. We can deal with the duplicate
> detection later during 1.9 bugfixing.
>
Ok. I made separate patch for the SRV part. It is in attachment.
Previous patch did not contain man page update. New patch attached.
Thanks
Michal