-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/28/2010 11:37 AM, Sumit Bose wrote:
Hi,
this patch should fix #239. All translatable strings are in the pam
client and now it should be quite easy to add new messages which should
be presented to the user.
It is quite easy to see this message for a console user, but currently a
GUI user needs a very fast eye to catch the message in the gdm or
screensaver window. Maybe we should ask the desktop people to send a
PAM_TEXT_INFO message e.g. with libnotify to the user's desktop.
bye,
Sumit
Nitpick:
In the sysdb-tests, could you please add a simple check for whether
expire_date is zero or nonzero (as appropriate). It probably wouldn't
hurt to set the offline expiration both on and off and have a test for each.
Otherwise the patch looks great.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAktm5C8ACgkQeiVVYja6o6N9vQCfSg5P3JhIf87r1JkTFIFtyKDX
Z/oAn3tLBoZeX7RA4P3Q2rR9ek+nEhS3
=wlye
-----END PGP SIGNATURE-----