Re: [SSSD] [PATCH 2/3] Carefully check records when forcibly invalidating
On 12/20/2012 06:10 AM, Simo Sorce wrote:
We should never try to invalidate an already invalid record as
internal pointers will not be consistent. Carefully test that the
record really is valid when we are fishing for free space, and
properly invalidate records or return a fatal error if something
goes wrong.
In order to make the code more robust always invalidate the whole
data space on initialization by setting all bits to 1, and make sure
to invalidate the whole last allocated slot by converting rec->len to
the number of slots instead of just the space used.
---
src/responder/nss/nsssrv_mmap_cache.c | 119 ++++++++++++++++++++++++++++-----
src/util/mmap_cache.h | 6 +-
2 files changed, 105 insertions(+), 20 deletions(-)
Ack to the code. Haven't tried it yet.