URL:
https://github.com/SSSD/sssd/pull/261
Title: #261: Add systemtap probes into the top-level data provider requests
jhrozek commented:
"""
On Mon, May 08, 2017 at 07:03:16AM -0700, Justin Stephenson wrote:
Thank you for the review Jakub.
I only added 2 Probe markers in the code to get the high-level request information, I can
add them into more places for this PR if you would like.
The question I'm thinking about is -- do we want to make the probes
exposed also for admins or support engineers?
If yes, then I think it would be nice if the probes were documented and at
least a bit stable. Of course not stable like we do keep our library APIs,
but more stable than our DEBUG messages.
I'm leaning towards documenting some of the probes. The probes at points
that correspond to fundamental sssd architectural decisions (data
provider, responding to a request from cache, ...) could IMO be
documented and we could even have a sssd-systemtap man page.
The probes that are in parts of code that are subject to change (like
the current probes that we have in the nested LDAP group resolution
code) don't have to be documented. Then the only way for an admin to
find about the probes is to check the code or the files under
/usr/share/systemtap -- and if the admin is able to do that, they are
able to cope with changes between versions.
I'm really interested to hear what do other developers think, though.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/261#issuecomment-299948587