On (16/09/13 12:15), Jakub Hrozek wrote:
On Mon, Sep 16, 2013 at 11:01:36AM +0200, Pavel Březina wrote:
> On 09/13/2013 04:52 PM, Lukas Slebodnik wrote:
> >ehlo,
> >
> >Attached patch resolves ticket #2075
> >
> >LS
>
> Hi,
> minor nack.
>
> >+ ret = sdap_get_netgroup_primary_name(memctx, opts, attrs, dom, &name);
> >+ if (ret != EOK) {
> >+ DEBUG(SSSDBG_OP_FAILURE, ("Failed to get netgroup name\n"));
> >+ goto fail;
> >+ }
>
> Wrong indentation ^^ otherwise LGTM
>
> Can you provide steps to reproduce please? I tries following netgroups:
>
> dn: cn=ng-1,ou=Netgroups,dc=ldap,dc=pb
> objectClass: top
> objectClass: nisNetgroup
> cn: ng-1
> cn: ng-3
> nisNetgroupTriple: (,,bobby,example.com)
> nisNetgroupTriple: (,,johny.example.com)
Would it trigger the bug if you reversed the order of the cn attributes?
Or would that make saving the netgroup fail in sssd_be?
I tried to:
1st step: remove one cn.
2nd step: add removed cn to another place
But LDAP server returned result in the same order. The order of attributes was
not changed
LS