On (07/12/15 15:51), Petr Cech wrote:
Hi Lukas,
thank you for review. I will send new version of tests, in one patch. And I
will address your comments.
However I would like to shed light on why I made the changes gradually. API
consists of three functions. I wanted every patch adding just one feature of
the API. First, I tested the function to open a database. Then I tested the
entry into the database, which influenced the opening. Finally, I tested
reading. I tried to build in the spirit of building a mathematical theory. It
helped me to think about different cases. And I thought it would help to
reviewer too...
Yes, but it's difficult to review code is you rename and move functions.
It is inevitable in some cases. But not in this case.
The purpose of ticket is add new test cases and not to move and rename
change functions. It just only mean that function was not reusable in
the 1st patch and should be changed there and not in following patch.
Well, I remake it in a single patch.
Moreover, I am not a single person who means that splitting tests
to separate patches is best idea.
Nikolai had similar request in another review.
https://lists.fedorahosted.org/archives/list/sssd-devel%40lists.fedorahos...
If you just add code then it's not a problem to review big patch
because you can read it as long article.
LS