On 03/18/2015 01:35 PM, Jakub Hrozek wrote:
On Wed, Mar 18, 2015 at 02:06:16AM +0100, Michal Židek wrote:
> Also I am not really sure why the src/tests/intg/slapd_setup
> and src/tests/intg/slapd_teardown are written in bash.
> It would be IMO better to write it all in python. The
> few external tools/programs can be called from python and
> the rest would be more readable if it was written
> in python (like the url_encode function, which to seems
> to be somehow cryptic in bash).
>
The other advantage would be that if we had a bit abstract class that
can bring up a process we could reuse it for KDC in the future, too.
Yes, that would be an advantage, but the size of common code for that would be
very small compared to the specific code needed to setup directory server(s)
and KDC. And that different code would benefit from being implemented in Bash,
IMO.
Nick