Re: [SSSD] [PATCH] build: add missing Requires to pkgconfig file
On Thu, Dec 19, 2013 at 07:42:36PM +0100, Jan Engelhardt wrote:
ini_comment.h uses simplebuffer.h, therefore must Require
basicobjects which provides that. Similarly, ini_valueobj.h uses
ref_array.h and must therefore Require ref_array.
---
ini/ini_config.pc.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ini/ini_config.pc.in b/ini/ini_config.pc.in
index 600d39a..66af169 100644
--- a/ini/ini_config.pc.in
+++ b/ini/ini_config.pc.in
@@ -6,6 +6,7 @@ includedir=@includedir@
Name: ini_config
Description: Library to process config files in INI format into a libcollection data
structure
Version: @INI_CONFIG_VERSION@
-Libs: -L${libdir} -lini_config -lcollection
+Requires: basicobjects ref_array collection
+Libs: -L${libdir} -lini_config
Cflags: -I${includedir}
URL: http://fedorahosted.org/sssd/
--
1.8.4
Thanks for the patch!
I think the change makes sense and reflects what we've had as RPM
Requires as well.
ACK