On (27/08/14 18:33), Sumit Bose wrote:
On Wed, Aug 27, 2014 at 11:31:27AM +0200, Lukas Slebodnik wrote:
> On (21/08/14 13:38), Sumit Bose wrote:
> >On Thu, Aug 21, 2014 at 01:27:58PM +0200, Jakub Hrozek wrote:
> >> On Wed, Aug 20, 2014 at 05:38:56PM +0200, Sumit Bose wrote:
> >> > > > wbcGetgrnam and wbcGetgrnam have wrong comments, but this
trivial bug is
> >> > > > also in Samba.
> >> > > >
> >> > > > Are you sure the asprintf() call in wbcLookupName is safe?
Could this
> >> > > > enable someone to trash the stack with a long enough name?
> >> > >
> >> > > I added some checks to prevent this.
> >>
> >> For some reason I thought that asprintf allocates on the stack like
> >> alloca and didn't see the call to free. In this case, I don't think
the
> >> check is needed.
> >
> >I think the NULL checks still make sense and if you agree I would keep
> >the others just as sanity checks.
> >
>
> libwbclient is installed by default with make install
> and there isn't way how to disable this behaviour.
> Should we add possibility to build (or install) library optionaly?
> It might help package maintainers.
Do you think attached patch would work?
Yes, thank you
From b92a817a5b984216f85ceb89f60e554a50d1c2e5 Mon Sep 17 00:00:00
2001
From: Sumit Bose <sbose(a)redhat.com>
Date: Wed, 27 Aug 2014 18:27:07 +0200
Subject: [PATCH] libwbclient: make build optional
---
Makefile.am | 5 ++++-
configure.ac | 1 +
src/conf_macros.m4 | 16 ++++++++++++++++
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 1b183d0..dd0ddb3 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -733,9 +733,12 @@ endif # BUILD_IFP
lib_LTLIBRARIES = libipa_hbac.la \
libsss_idmap.la \
libsss_nss_idmap.la \
- libwbclient.la \
$(NULL)
+if BUILD_LIBWBCLIENT
+lib_LTLIBRARIES += libwbclient.la
+endif #BUILD_LIBWBCLIENT
+
pkgconfig_DATA += src/providers/ipa/ipa_hbac.pc
libipa_hbac_la_DEPENDENCIES = src/providers/ipa/ipa_hbac.exports
libipa_hbac_la_SOURCES = \
Almost ACK.
wbclient.pc should not be installed if sssd is built without libwbclient.
@@ -770,7 +770,11 @@ libsss_nss_idmap_la_LDFLAGS = \
dist_noinst_DATA += src/sss_client/idmap/sss_nss_idmap.exports
+
+if BUILD_LIBWBCLIENT
pkgconfig_DATA += src/sss_client/libwbclient/wbclient.pc
+endif #BUILD_LIBWBCLIENT
+
EXTRA_libwbclient_la_DEPENDENCIES = src/sss_client/libwbclient/wbclient.exports
libwbclient_la_SOURCES = \
src/sss_client/libwbclient/wbc_guid.c \
LS