On 11/06/2014 12:09 PM, Lukas Slebodnik wrote:
> + DEBUG(SSSDBG_TRACE_FUNC, "performing selinux
operations\n");
> +
> + ret = set_seuser(ibuf->username, ibuf->seuser, ibuf->mls_range);
> +
> + ret = prepare_response(main_ctx, ret, &resp);
^^^
return value is not tested. It might happen that resp will not be used
initialized in sss_atomic_write_s.
> +
> + errno = 0;
> +
> + written = sss_atomic_write_s(STDOUT_FILENO, resp->buf, resp->size);
> + if (written == -1) {
> + ret = errno;
> + DEBUG(SSSDBG_CRIT_FAILURE, "write failed [%d][%s].\n", ret,
> + strerror(ret));
> + goto fail;
> + }
html report from clang is attached.
LS
Thanks, please see the attached simple patch.
Michal