On Thu, Aug 27, 2015 at 01:05:00PM +0200, Lukas Slebodnik wrote:
On (24/08/15 16:09), Michal Židek wrote:
>On 08/21/2015 04:55 PM, Petr Cech wrote:
>>On 08/21/2015 02:35 PM, Michal Židek wrote:
>>>Hi,
>>>
>>>some of the tests you deleted are valid and
>>>should not be deleted.
>>>
>>>Only those tests that rely on time(NULL)
>>>being the same as the time of request
>>>creation are invalid. All those that test old
>>>entries or nonexistent entries are OK.
>>>See comments inline.
>>I agree.
>>Those tests have another logic. So I returned them back.
>>Petr
>>
>
>ACK.
>
>CI results:
>http://sssd-ci.duckdns.org/logs/job/23/75/summary.html
>
+1 for patch.
but please do not close the ticket #2730
OK, I changed "Resolves" to "Works Around" in the commit message and
pushed the patch to master:
bdf422fde0fd6b40b3412bad3b200f8fd7ea8693
after pushing to master. This solution is just a temporary
workaround for problematic tests.
What do you think would be the solution? I thought Michal and Petr
concluded that the tests were simply invalid..