Re: [SSSD] [PATCH] sss_override: support import and export

[Pavel Březina]

On 08/17/2015 10:32 AM, Jakub Hrozek wrote:
> On Sun, Aug 16, 2015 at 05:59:22PM +0200, Pavel Březina wrote:
> > https://fedorahosted.org/sssd/ticket/2737
> >
> > Hi, it should work... :-) However, I wanted to make import as transaction so
> > no changes are made if some error occurs, but I had some troubles with it so
> > I gave up eventually.
>
> Thanks a lot for the patches. I didn't do any review yet, just scrolled
> through them.
>
> My first reaction was that the second patch should be split up and at
> least the colondb should be unit tested.

Ok. Do you have any specific split on mind?
> btw did you get inspired by some existing code, like libuser or
> shadow-utils with the colondb?

Nope.