On Tue, 2013-11-05 at 08:04 -0500, Simo Sorce wrote:
The patch looks ok to me as is, however some of the function have
become
verbose because you used the raw copying macros.
What about having setters and getters for cmd and status too ?
Then sss_packet_get_cmd() becomes simply:
{
return (enum sss_cli_command)sss_packet_get_cmd(packet);
}
which more closely matches the current code.
ROTFL, and this is the classic example of rewriting your email while
reading the code and not proof reading it at the end :-)
Ignore this part, just look at the next bit.
Also minor nack, the new functions you introduced are not
namespaced.
Please packet_get_len() -> sss_packet_get_len() and so on.
I know these are static for now, but let's keep a naming consistent with
sss_packet_set_error() and sss_packet_get_body() etc ...
Simo.
--
Simo Sorce * Red Hat, Inc * New York