On 09/13/2012 07:26 PM, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed 12 Sep 2012 09:12:08 AM EDT, Michal Židek wrote:
> On 09/12/2012 02:39 PM, Michal Židek wrote:
>> Patch 1 - tools_util.h now provides signal_sssd function. It
>> replaces send_sighup function from sss_debuglevel.c. It can
>> be used to send any signal to monitor (used in patch 2).
>>
Ack
>> Patch 2 -
https://fedorahosted.org/sssd/ticket/1311
>>
Please rename nss_logrotate() to nss_hup(). It's not just rotating
logs, so I'd rather it be less confusing.
Done.
Also:
+ struct nss_ctx *nctx = (struct nss_tx*)rctx->pvt_ctx;
you're casting to a typoed type.
Good catch, however, I wonder how is it possible, that the
code even worked. Some kind of black compilation magic.
I'd prefer to leave the review of the sss_mmap_cache_invalidate()
routine to Simo, as he's more familiar with the code.
Yes. I mostly reused Simos code, so he is probably the right
person to review it.
Sending both patches again.
Thanks
Michal