combined unit test patch for find_uid and io added.
On Sat, Mar 23, 2013 at 12:17 AM, Abhishek Singh <
abhishekkumarsingh.cse(a)gmail.com> wrote:
changes done.
On Sat, Mar 23, 2013 at 12:07 AM, Stephen Gallagher <sgallagh(a)redhat.com>wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 03/22/2013 02:33 PM, Abhishek Singh wrote:
> > New tests added to success tests. Please review it.
> >
>
> Almost :)
>
> You can't just test for integer equivalence, because it's conceivable
> that there may be other flags returned beyond just the FD_CLOEXEC flag.
>
> You need to do:
> assert_true(ret_flag & FD_CLOEXEC)
>
> The bitwise comparison will ensure that it's non-zero if the
> FD_CLOEXEC flag is set.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.13 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
>
> iEYEARECAAYFAlFMpO4ACgkQeiVVYja6o6OJsQCfeifrXZefJL2CfKR5qFl267XG
> LzwAn2AzSlodw/YfT1phEHOFuk6fTXSs
> =EyN7
> -----END PGP SIGNATURE-----
>
_______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>